This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 382
Depend on ruby virtual package #1860
Open
adipascu
wants to merge
1,214
commits into
heroku:master
Choose a base branch
from
adipascu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is now down in the API: https://github.com/heroku/api/pull/4587
…ename-patch Revert "Merge pull request heroku#1682 from heroku/omarkj-rename-performanc…
remove auto tier switching
remove foreman and fix el capitan
now that foreman is gone, a directory was missing
ensure that /usr/local/bin exists before creating the symlink there
remove double responde_to check
This changes `heroku apps --space` to use the updated v2 org apps endpoint that now includes the space attribute. Unjoined apps in spaces are now displayed and the rest of the space query and display logic falls inline with orgs now. This also has the side benefit of validating space visibility to improve error messages for unauthorized access.
ensure that HEROKU_HEADERS are used for pg:backups commands
This changes the org app list to always display joined and unjoined apps together in one list for parity with Dashboard. Hiding and segregating unjoined apps has proved to confuse users. This leaves the --all option in place, but updates the documentation to reflect what is actually does for the personal app list.
Fix `heroku apps --space` to display unjoined apps
Always display unjoined org apps
master: Always display unjoined org apps
support custom kernels
added arrows added request POST body output
HEROKU_DEBUG improvments
clear up unknown database error
Add plugins:command to track progress
Platform api requests that don't specify a version will default to v2. We want requests that return information about spaces or org apps to go to v3 instead
spaces: don't use platform api dogwood variant
* fixes unicode problems on windows
Remove readline dep & unused protected methods
Change exec(args) to exec(shelljoin(string))
such as whether or not the plugin is symlinked
The underlying problem is that ENV variables with cryllic characters come in as ASCII-8BIT rather than utf-8 * https://bugs.ruby-lang.org/issues/9715
Be more descriptive about uninstalling Accounts
show extra plugin info
Fix Windows cryllic character from ENV issues
Revert exec to shellescape while I fix windows bug
Use system & exit on windows when non-ascii args
This will fix the current issue on debian and future proof the dependency. libssl and libreadline are required by ruby.
what issue does this fix exactly? I'm also not sure it will work for older ubuntu versions. |
The issue is is a broken dependency in debian/testing. Debian currently lacks ruby 2.1 in favor of ruby 2.2 Instead of depending on a specific version i'd rather use the virtual package to prevent future dependency issues. The ruby virtual package exists in all currently supported versions of ubuntu and debian, it also pulls in a ssl lib and the readline lib. |
@dickeyxxx Can confirm issue on Debian stretch:
|
👍 Looks like the ruby virtual package is in old Ubuntu and Debian repos |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the current issue on debian and
future proof the dependency.
libssl and libreadline are required by ruby.